search

coinbase / react-coinbase-commerce

Coinbase Commerce React
Apache License 2.0
93 stars 56 forks source link

New React (16.5.2) breaks react-coinbase-commerce library #11

Closed neocybereth closed 6 years ago

neocybereth commented 6 years ago

Just a heads up, if you install the new version of Create-React-App and try and use this library it will break it. I have found the fix though.

In this portion of the code: .amd?define("react-coinbase-commerce",["React"],t)

delete ["React"] and it will work.

tbtstl commented 6 years ago

@Sm00g15 I'm unable to recreate this issue, is it something you're still encountering?

tbtstl commented 6 years ago

Closing for now, feel free to reopen the issue if you're still encountering it.

neocybereth commented 6 years ago

yeah, just tested it and I'm still getting that error on the newest version of React

neocybereth commented 6 years ago

but the solution still holds true.