Closed pegahcarter closed 5 months ago
Nevermind. Looks like this was resolved with #9 .
Thanks @pegahcarter, this is documented behavior https://github.com/coinbase/smart-wallet/blob/main/src/MultiOwnable.sol#L6
https://github.com/coinbase/smart-wallet/blob/main/src/MultiOwnable.sol#L43-L51
Summary
A user may unintentionally get blocked from adding new owners.
Description
When adding an owner, the
nextOwnerIndex
is incremented. However, when removing an owner,nextOwnerIndex
remains the same. Once 255 owners have been added, a user is unable to add owners because of the uint8 overflow within_addOwner()
. This limitation will still exist even after owners have been removed, asnextOwnerIndex
will still be 255.