Refactor _validateSignature to allow Smart Wallets to sign for other Smart Wallets

coinbase / smart-wallet

MIT License

284 stars 54 forks source link

Refactor _validateSignature to allow Smart Wallets to sign for other Smart Wallets #13

Closed wilsoncusack closed 5 months ago

wilsoncusack commented 5 months ago

While discussing ERC-1271 with @xenoliss, we realized that there is currently no way for Smart Wallet to sign via ERC-1271 for another Smart Wallet. To fix this, we make _validateSignature primarily switch on the ownerBytes length, rather than the signature length, which cleans up the code and allows us to remove a couple errors entirely.

cb-heimdall commented 5 months ago

Review Error for xenoliss @ 2024-03-07 12:06:25 UTC User must have write permissions to review