search

coinbase / smart-wallet

MIT License
284 stars 54 forks source link

bug: missing 0 checks #16

Closed pegahcarter closed 5 months ago

pegahcarter commented 5 months ago

We should add validations within addOwnerAddress() and addOwnerPublicKey() to require that the owner != 0.

wilsoncusack commented 5 months ago

Thanks, but we do not intend to add these kinds of checks. There are many erroneous addresses that could be passed and we cannot control for all of them.

pegahcarter commented 5 months ago

Just note that if owner 0 is added, it can never be removed.