search

coinbase / smart-wallet

MIT License
284 stars 54 forks source link

exploring gas of using oz #25

Closed wilsoncusack closed 5 months ago

wilsoncusack commented 5 months ago

before

Screenshot 2024-03-10 at 8 14 54 PM

after

Screenshot 2024-03-10 at 8 14 30 PM

Looks pretty good except 170k gas hit on upgrade 😬

wilsoncusack commented 5 months ago

Alchemy recently used Solady UUPS with OZ Clone, we could do the same https://github.com/alchemyplatform/modular-account

wilsoncusack commented 5 months ago

Interestingly if I had Solady UUPS back in the gas doesn't get much better, investigating.

here

Screenshot 2024-03-10 at 10 09 32 PM

main

Screenshot 2024-03-10 at 10 10 31 PM

only think I can think is bytecode size change allowing for more optimizations? But I can't really think how that would actually be the case.

wilsoncusack commented 5 months ago

Not pursuing for now