Fix flaky test `test_cannotCallExec`

coinbase / smart-wallet

MIT License

258 stars 47 forks source link

Fix flaky test `test_cannotCallExec` #35

Closed stevieraykatz closed 3 months ago

stevieraykatz commented 3 months ago

The test for test_cannotCallExec had an expanded scope that leveraged an integrated EntryPoint. In order to work as an integration test, the call incorporated gas costs which could fluctuate during testing. This ended up making it flaky.

This PR spoofs the entry point and calls the method directly then tests whether we see the expected revert case.

cb-heimdall commented 3 months ago

Review Error for wilsoncusack @ 2024-03-18 19:48:43 UTC User failed mfa authentication, see go/mfa-help