search

coinbase / smart-wallet

MIT License
258 stars 47 forks source link

rename a variable name to fix a Rust binding issue #47

Closed 37ng closed 2 months ago

37ng commented 3 months ago

The $ will be named as _ when creating Rust bindings, which is a reserved identifier. Rename it to addr to fix it.

binding code generated by forge bind that doesn't compile:

  pub struct ImplementationReturn {
      pub _: ::ethers::core::types::Address,
  }
37ng commented 3 months ago

This is apparently a foundry issue, but it would help unlock development simply by a renaming : )

wilsoncusack commented 3 months ago

Interesting! Using $ is pretty idiomatic for this and I haven't had issues with forge. Is there specific workflow this is blocking?

37ng commented 3 months ago

Importing in Rust is blocked. Like I said this is a small issue simply by renaming the variable and rebuild it.