search

coinbase / smart-wallet

MIT License
284 stars 54 forks source link

No CI #5

Closed pegahcarter closed 5 months ago

pegahcarter commented 5 months ago

I propose adding a CI pipeline so that any local work of the repo can be guaranteed to build. The current commit (5bad101) breaks on build, slowing down development time for internal team and public contributors.

pegahcarter commented 5 months ago

For example, something like https://github.com/FraxFinance/frax-template makes development on new repositories super simple. It also use pnpm, a faster alternative to .gitmodules, and supports all protocol-wide contract imports (a challenge when working across repos).

wilsoncusack commented 5 months ago

Thanks! We had some non-public deps that broke CI before launch but I have a branch with a workflow for tests and lint. Will put up

pegahcarter commented 5 months ago

If you switch from .gitmodules to node_modules you'll be able to depend on private deps.

wilsoncusack commented 5 months ago

Roger, not an issue anymore!