coinbase / smart-wallet

MIT License
258 stars 47 forks source link

Allow passing implementation address to factory #51

Closed wilsoncusack closed 3 months ago

wilsoncusack commented 3 months ago

A single factory with a frozen implementation address was chosen to

  1. Ensure users could get the same address across as many chains as possible
  2. Ensure users would opt into all upgrades and never be forced to upgrade via a factory on some chain having a new implementation.

However, the downside of our current approach is that totally new users in the future will create an account and then immediately need to call to upgrade their account to the last version. It would be better if new users could pass the implementation they want to use. They then would need to pass this same implementation on all future chains where they want the same address. This PR enables that.

Supersedes #50

wilsoncusack commented 3 months ago

Decided against this: