Opinion: can reduce arguments of `removeOwner()`

coinbase / smart-wallet

MIT License

258 stars 47 forks source link

Opinion: can reduce arguments of `removeOwner()` #62

Closed pegahcarter closed 2 months ago

pegahcarter commented 2 months ago

From: https://github.com/coinbase/smart-wallet/blob/adab965145cc7a6f938dd118295c6ae062672838/src/MultiOwnable.sol#L122

It seems a bit redundant to require the caller to pass in both the index and the bytes. Perhaps two overloading methods would suffice, one for index only and one for the bytes?

wilsoncusack commented 2 months ago

Thanks! See https://github.com/coinbase/smart-wallet/pull/42