coinbase / temporal-ruby

Ruby SDK for Temporal
Apache License 2.0
225 stars 84 forks source link

NameError: uninitialized constant Temporal::VERSION #237

Closed bmorton closed 1 year ago

bmorton commented 1 year ago

I just updated to the latest SHA and noticed some recent additions for custom search attributes that I wanted to test out. However, I've run into this exception while trying to call Temporal.add_custom_search_attributes. In my codebase, if I add require "temporal/version" in an initializer, everything is good. Do we need to do that somewhere in the gem? Should it be required here? Happy to open a PR if it's helpful!

rake aborted!
NameError: uninitialized constant Temporal::VERSION
Did you mean?  REVISION
/opt/app/laddertruck/vendor/bundle/ruby/3.0.0/bundler/gems/temporal-ruby-59ed5911850e/lib/temporal/connection/interceptors/client_name_version_interceptor.rb:8:in `request_response'
/opt/app/laddertruck/vendor/bundle/ruby/3.0.0/gems/grpc-1.38.0/src/ruby/lib/grpc/generic/interceptors.rb:175:in `intercept!'
/opt/app/laddertruck/vendor/bundle/ruby/3.0.0/gems/grpc-1.38.0/src/ruby/lib/grpc/generic/client_stub.rb:179:in `request_response'
/opt/app/laddertruck/vendor/bundle/ruby/3.0.0/gems/grpc-1.38.0/src/ruby/lib/grpc/generic/service.rb:171:in `block (3 levels) in rpc_stub_class'
/opt/app/laddertruck/vendor/bundle/ruby/3.0.0/bundler/gems/temporal-ruby-59ed5911850e/lib/temporal/connection/grpc.rb:511:in `add_custom_search_attributes'
/opt/app/laddertruck/vendor/bundle/ruby/3.0.0/bundler/gems/temporal-ruby-59ed5911850e/lib/temporal/client.rb:415:in `add_custom_search_attributes'