search

coinbase / temporal-ruby

Ruby SDK for Temporal
Apache License 2.0
238 stars 89 forks source link

Require "temporal/version" so Temporal::VERSION can be referenced #238

Closed bmorton closed 10 months ago

bmorton commented 1 year ago

I ran across this after pulling the latest SHA. This fixes #237 for me when I use this branch.

jeffschoner commented 1 year ago

This is similar to a PR I just created at https://github.com/coinbase/temporal-ruby/pull/241, but I think mine is more correct since it more tightly scopes the require to only where it's strictly needed. What do you think? Does my version also allow you to load?

mjameswh commented 1 year ago

I would also go with #241.

DeRauk commented 10 months ago

Closed because it's been fixed with #241