Support Terraform 0.12.x

[inductor]

The latest released version doesn't seem to work well with Terraform 0.12.x

[FernandoMiguel]

What benefit do you see in landscape for 012? The plan is so much more readable that I no longer see a need for it

-- Fernando Miguel

On Tue, 11 Jun 2019, 08:18 Kohei Ota, notifications@github.com wrote:

The latest released version doesn't seem to work well with Terraform 0.12.x

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/coinbase/terraform-landscape/issues/101?email_source=notifications&email_token=AABJDLVNIGYZAPLVDPQ6KGDPZ5GTBA5CNFSM4HW3HYW2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYXNGHA, or mute the thread https://github.com/notifications/unsubscribe-auth/AABJDLQD4FTJ7TKAZOH5Y7DPZ5GTBANCNFSM4HW3HYWQ .

[remipichon]

It's true the 012 plan is much more readable but way too verbose. However Landscape is doing a great job of just output what is actually needed in most case. I have in mind the infinite "refreshing state".

[inductor]

I've been using landscape as a "simpler-terraform-plan-result" tool. as @remipichon said even on 0.12 it is still kind of annoying to see the bunch of "refreshing state" messages and would just like to see the diff from the current state.

[remipichon]

@inductor you can easily "hide" the "refreshing state" with terraform plan | grep -v "Refreshing state...". However Landscape was doing more than just hiding those logs, it was doing a great deal of just showing the actual diff and not the whole +/-/unchanged ressources attributes.

[nunofernandes]

Completely agree with @remipichon . Terraform 0.12 is way verbose showing things that will remain the same with apply.

[inductor]

Is this gonna happen or not? :P

[sds]

We would welcome a well-tested pull request that preserves functionality for users who are still on Terraform 0.11.x. Thanks!

[neon-sombrero]

The v0.12 plan is definitely more readable, but I would agree with @remipichon that landscape does a better job of showing the actual diffs. It would be great if it could support v0.12!

[servo1x]

Landscape is still useful for diffing large blocks of text. For example when using the helm provider, you can pass in a yaml file. Landscape will pretty format it and show the relevant diff, while terraform 0.12 does not do that and that makes it difficult to see what changed.

[jasonmalstrom]

an improvement would be to add color to the entire element being created, destroy, or modified, instead of just the -/+/~

[sbz]

Terraform landscape output was really great and definitively more readable with colors and diff-like output. I would love to be able to use it for Terraform 0.12.x 👍

[eredi93]

Same

[james-gonzalez]

For things like ECS task definitions where you have many tasks in a single file ? That would be a good one :)

[davidgereb]

for jsonencoded maps for ECS task defs in 0.12 is not showing the changes, but the replacement of the whole json :( it'd be nice to use the tool for things like that

[lewisstevens1]

Would like this feature also.

[laxin84]

I, too, would love to see this.

[sasq31]

+1

[sds]

I've locked this issue to prevent further "+1" comments that aren't helpful. Would welcome a pull request adding support for the 0.12 output syntax!