coinbase / terraform-landscape

Improve Terraform's plan output to be easier to read and understand
Apache License 2.0
1.59k stars 116 forks source link

Fixes an issue with processing attribute names that include colons. #34

Closed krobertson closed 7 years ago

krobertson commented 7 years ago

This fixes an issue with processing resource attribute names that included colons. This is primarily possible when a tag name includes a colon.

The issue is with the parser grammer only matching an attribute name up until the colon. It was then failing to evaluate the content since it included extra data. This changes it to use a lookahead matcher to look for :.

Note that this still will be a problem if tag names are using :, however I'm unsure if treetop can do a regex that matches the last occurrance within a line.

FYI @tmatilai

Fixes #32