search

coinbase / terraform-landscape

Improve Terraform's plan output to be easier to read and understand
Apache License 2.0
1.59k stars 116 forks source link

Scrub dashed lines from Terraform output before parsing #39

Closed mikeflisher closed 7 years ago

mikeflisher commented 7 years ago

Resolves issue: #37

Terraform output can contain dashed lines followed by new lines before output match by regexp.

This scrubs the dashes and new lines before parsing the output and moves the no changes match above the other parsing code.

More details in issue comment: https://github.com/coinbase/terraform-landscape/issues/37#issuecomment-336341627

TF Output before scrubbing:

------------------------------------------------------------------------

No changes. Infrastructure is up-to-date.

TF Output after scrubbing:

No changes. Infrastructure is up-to-date.

Probably want to look at updating the test inputs as well.

krobertson commented 7 years ago

@mikeflisher can you add a test to confirm it is not fixed?

sds commented 7 years ago

Closing due to lack of response, as well as the fact that I don't believe this output is coming from Terraform. Feel free to reopen with a reproducible example. Thanks!

mikeflisher commented 7 years ago

I've run a variety of tests against TF 0.10.5 output with the terraform_landscape 0.15 and 0.16 and couldn't reproduce the same error so assuming fixed as well.