coinbase / terraform-landscape

Improve Terraform's plan output to be easier to read and understand
Apache License 2.0
1.59k stars 116 forks source link

Support `terraform apply`? #53

Closed glenjamin closed 6 years ago

glenjamin commented 6 years ago

As terraform apply now produces a diff and then prompts for a yes to apply, it would be neat if landscape could handle this too.

I hope this would mostly be a case of streaming the output through rather than buffering - but it might be more involved.

sds commented 6 years ago

Hey @glenjamin, would love to merge a pull request adding support for streaming!

glenjamin commented 6 years ago

I had a bit of a look into this. It seems doable but a bit more invasive than i'd initially hoped.

A high level outline of what is required to do this properly:

This would be cool as you'd also get incremental feedback - and could even maybe pass-through some of the underlying terraform incremental feedback messages?

While writing this up I realised this is overthinking it somewhat, and there's a cheat's way to do this:

I'm going to have a go at the latter at some point, and I might have a go at the former if i'm feeling adventurous.

sds commented 6 years ago

Implemented in #54.

glenjamin commented 6 years ago

Do you think it's worth leaving an issue open for full streaming support in case someone else runs into it and wants to give it a go?