search

coinbase / terraform-landscape

Improve Terraform's plan output to be easier to read and understand
Apache License 2.0
1.59k stars 116 forks source link

Add Dockerfile to run landscape on alpine #63

Closed pratikmallya closed 6 years ago

pratikmallya commented 6 years ago

I had trouble when trying to get landscape running in the same container as atlantis, which uses alpine. This Dockerfile will hopefully help others prevent having to spend hours figuring out how to make landscape work on alpine.

pratikmallya commented 6 years ago

It would also be nice to provide a docker image running landscape from docker hub. Something similar to what I've done here: https://github.com/pratikmallya/Dockerfiles/blob/master/.travis.yml

pratikmallya commented 6 years ago

Ping. Can this be merged? Any more changes required to get it merged?

sds commented 6 years ago

Hey @pratikmallya, thanks for the PR.

This Dockerfile on its own doesn't provide much value unless we include documentation on how to use it.

Since we don't run Landscape via Docker, we have no intention to release/maintain an image on Docker Hub. Encourage users to manage this themselves.

If you submit some documentation to accompany this Dockerfile, we can merge it. Thanks!

pratikmallya commented 6 years ago

@sds updated README; let me know if that works. Totally understandable that you don't want to deal with the pain of maintaining docker images on Dockerhub yourself.

pratikmallya commented 6 years ago

@sds fixed

sds commented 6 years ago

Thanks @pratikmallya.