Fix fail parse attribute value

coinbase / terraform-landscape

Improve Terraform's plan output to be easier to read and understand

Apache License 2.0

1.59k stars 116 forks source link

Closed dozen closed 6 years ago

dozen commented 6 years ago

Issue: #62

As you can see from Issue # 62, using eval expands the value like "#{host}".

So instead of using eval we change it to parse attribute value using regular expression and string_undump.

Since String # undump is a method introduced from Ruby 2.5, we will make it work with Ruby 2+ by using the string_undump package.

sds commented 6 years ago

I merged too soon—didn't realize the CircleCI tests were failing. Reverted in 12acca18.

I'll work on getting the CircleCI tests reporting to this repo again. Please adjust the PR so the tests pass, and resubmit. Thanks!

dozen commented 6 years ago

I'm so sorry...

I'll correct in #77