Print warning messages - Githubissues

coinbase / terraform-landscape

Improve Terraform's plan output to be easier to read and understand

Apache License 2.0

1.59k stars 116 forks source link

Closed LTMenezes closed 6 years ago

LTMenezes commented 6 years ago

Hi everyone!

I just found issue https://github.com/coinbase/terraform-landscape/issues/66 and I decided that it was worth making a PR, just like @sds commented on the issue.

Every terraform warning was being suppressed, in this PR landscape starts to output it in yellow.

This is my first PR to this project so any feedback is very welcome.

sds commented 6 years ago

Thanks for the PR, @LTMenezes!

Can you add a test so we don't break this behavior in future changes? Happy to merge with a test. Thanks!

LTMenezes commented 6 years ago

Sure @sds, I will add them as soon as I can!

LTMenezes commented 6 years ago

@sds I added a test to cover this behavior, let me know if there's anything missing!

sds commented 6 years ago

Thanks @LTMenezes!