search

coinbase / waas-sdk-react-native

Coinbase Wallet as a Service (WaaS) SDK for React Native. Enables MPC Operations for iOS and Android Devices.
https://docs.cloud.coinbase.com/waas
Other
234 stars 104 forks source link

Change yarn installation requirement to yarn classic #13

Closed yuga-cb closed 1 year ago

yuga-cb commented 1 year ago

Change yarn installation requirement to yarn classic

ghost commented 1 year ago

Done.

However, now that i think about it, i understand how this readme could be a bit confusing, especially if you’re just blindly following the instructions.

You don’t actually need to install yarn unless you want to use it instead of npm. So labelling both node and yarn as Pre-requisites was confusing, esp in case of Leonard’s installation.

Omit Yarn as a pre-requisites. looking at other projects, they just don’t even specify node or yarn as a pre-requisites since most devs have it already. Instead if they don’t have it when they go to yarn add, they will get a prompt to install.

yuga-cb commented 1 year ago

Yarn as a pre-requisites. looking at other projects, they just don’t even specify node or yarn as a pre-requisites since most devs have it already. Instead if they don’t hav

Acknowledged; however, the default react native tooling for react native libraries uses yarn, hence our dependency on it.