Closed bdusauso closed 3 years ago
Hi, would be great to have this.
instead of a hash I think it's more idiomatic to use a keyword, like this:
I think would be better to leave map because of backward compatibility.
Hi, would be great to have this.
I will provide a PR as soon as possible.
instead of a hash I think it's more idiomatic to use a keyword, like this:
I think would be better to leave map because of backward compatibility.
Oh, I see. At the end it's just a matter of consistency and taste 😃
Awesome 👍
See PR #12
As I can see from RabbitConnection it's not possible to pass other options than
url
andtimeout
to the connection. In order to support, for example, SSL, it would be nice to pass these options directly toAMQP.Connection.open/2
.Moreover, instead of a hash I think it's more idiomatic to use a keyword, like this:
What do you think ?