search

coingaming / coney

Consumer server for RabbitMQ with message publishing functionality.
MIT License
42 stars 9 forks source link

Issue #5 bind to default exchange #6

Closed DanilParshukov closed 5 years ago

DanilParshukov commented 5 years ago

Hi, @llxff ! I've added support for the default exchange. But the pull request is still WIP, because I don't know how to handle tests. It is impossible to cover new code with tests using FakeConnection, so I need to connect to real RabbitMq. If it is ok, that the project will require connection to RabbitMq during testing, I will add it, otherwise I will resolve WIP status. Anyway, I've tested it by myself many times.

llxff commented 5 years ago

Hi, @DanilParshukov, thank you for your PR! Looks great!

If it is ok, that the project will require connection to RabbitMq during testing

It is ok, you can do it 👍

DanilParshukov commented 5 years ago

@llxff thank you for feedback! I updated readme, wrote tests, and removed declare_exchange(_, nil). Please, review it again)

llxff commented 5 years ago

Well done, @DanilParshukov!

Is it ready to merge?

DanilParshukov commented 5 years ago

Well done, @DanilParshukov!

Is it ready to merge?

@llxff , yes, please

llxff commented 5 years ago

published in 2.0.2

DanilParshukov commented 5 years ago

published in 2.0.2

Awesome! Thank you!