Closed DanilParshukov closed 5 years ago
Hi, @DanilParshukov, thank you for your PR! Looks great!
If it is ok, that the project will require connection to RabbitMq during testing
It is ok, you can do it 👍
@llxff thank you for feedback! I updated readme, wrote tests, and removed declare_exchange(_, nil)
.
Please, review it again)
Well done, @DanilParshukov!
Is it ready to merge?
Well done, @DanilParshukov!
Is it ready to merge?
@llxff , yes, please
published in 2.0.2
published in 2.0.2
Awesome! Thank you!
Hi, @llxff ! I've added support for the default exchange. But the pull request is still WIP, because I don't know how to handle tests. It is impossible to cover new code with tests using FakeConnection, so I need to connect to real RabbitMq. If it is ok, that the project will require connection to RabbitMq during testing, I will add it, otherwise I will resolve WIP status. Anyway, I've tested it by myself many times.