fix: Fix avatar to set backgroundImage to none instead of `url(undefined)` when imageUrl is not set

coingaming / moon-design

Moon Design System for React

https://moon.io/

MIT License

273 stars 27 forks source link

fix: Fix avatar to set backgroundImage to none instead of `url(undefined)` when imageUrl is not set #2522

Closed zsolteszku closed 9 months ago

zsolteszku commented 11 months ago

The url(undefined) is resulting to http requests to {domain}/undefined so the console and the network tab is full or errors.

Screenshot and description

Checklist

[x] You attached screenshots or added description about changes
[x] You use conventional commits naming, e.g. fix: your changes description [TicketNumber], feat: your feature name [TicketNumber]
[x] You have updated the documentation accordingly.

changeset-bot[bot] commented 11 months ago

⚠️ No Changeset found

Latest commit: 29c2bb5d1bf92b33d15c748d60ee257de6eca332

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR