What is the purpose of this Pull Request?
Add support for Uniswap V2
Uniswap V2 only support for ETH target pair
Need to derive base volume using DAI-ETH as conversion
What is the related issue for this Pull Request (if this PR fixes issue, prepend with "Fixes" or "Closes")?
[x] I have added Specs
[x] (If implementing Market Ticker) I have verified that the volume refers to BASE
[x] (If implementing Market Ticker) I have verified that the base and target is assigned correctly
[x] I have implemented the trade_page_url method that links to the exchange page with the base and target passed in. If not available, enter the root domain of the exchange website.
[x] I have verified at least ONE ticker volume matches volume shown on the trading page (use script below)
client = Cryptoexchange::Client.new
pairs = client.pairs 'exchange_name'
tickers = pairs.map do |p| client.ticker p end
sorted_tickers = tickers.sort_by do |t| t.volume end.reverse
What is the purpose of this Pull Request? Add support for Uniswap V2 Uniswap V2 only support for ETH target pair Need to derive base volume using DAI-ETH as conversion
What is the related issue for this Pull Request (if this PR fixes issue, prepend with "Fixes" or "Closes")?
[x] I have added Specs
[x] (If implementing Market Ticker) I have verified that the
volume
refers to BASE[x] (If implementing Market Ticker) I have verified that the
base
andtarget
is assigned correctly[x] I have implemented the
trade_page_url
method that links to the exchange page with thebase
andtarget
passed in. If not available, enter the root domain of the exchange website.[x] I have verified at least ONE ticker volume matches volume shown on the trading page (use script below)