Check if the volume are assigned correctly

coingecko / cryptoexchange

[UNMAINTAINED] Ruby library to query market data from cryptocurrency exchanges (https://www.coingecko.com)

https://www.coingecko.com

MIT License

300 stars 240 forks source link

Check if the volume are assigned correctly #56

Closed tmlee closed 7 years ago

tmlee commented 7 years ago

The volume under Ticker should refer to the base currency. Need to check all existing implementation exchanges if that value is correct.

tmlee commented 7 years ago

List of exchanges, verified volume assigned correctly

[/] anx
[/] bitcoin_indonesia
[/] bitflyer
[] bithumb
[/] bitstamp
[/] bittrex

...

tmlee commented 7 years ago

@dominicwong617 @Swingcloud Could you double confirm for the exchanges you have implemented if the volume is assigned correctly? That is it should be the base.

Other than the exchanges that i mentioned above, and after checking it. just comment and list them here if they are good? So i can double check the remainder

Swingcloud commented 7 years ago

will do today @tmlee

Swingcloud commented 7 years ago

checked:

/anx
/bitcoin_indonesia
/bitfinex
/bitflyer
/bithumb
/bitstamp
/bittrex
/bleutrade (wrong, WIP)
/btcc
/bter
/ccex
/coin_exchange (wrong, WIP)
/coincheck
/coinone
/cryptopia (wrong, WIP)
/ether_delta (wrong, WIP)
/gatecoin
/gdax
/gemini
/hitbtc
/korbit
/kraken
/lakebtc
/liqui
/livecoin
/novaexchange
/okcoin
/poloniex
/quoine
/yobit

Swingcloud commented 7 years ago

I fix this on #68

d0minicw0ng commented 7 years ago

@Swingcloud Thank you for checking for me as well 👏 👏 👏

tmlee commented 7 years ago

Apparently BTER had their base/quote definition swapped as well http://data.bter.com/api2/1/ticker/btc_cny

Need to be extra careful and look at the numbers really.

Swingcloud commented 7 years ago

the latest check list

[x] anx
[x] bitcoin_indonesia
[x] bitfinex
[x] bitflyer
[x] bithumb
[x] bitstamp
[x] bittrex - use Volume
[x] bleutrade - use Volume
[x] btcc
[x] bter
[x] ccex
[x] chbtc
[x] coin_exchange
[x] coincheck
[x] coinone
[x] cryptopia - use Volume
[x] ether_delta - use quoteVolume
[x] gatecoin
[x] gdax
[x] gemini
[x] hitbtc
[x] jubi
[x] korbit
[x] kraken
[x] lakebtc - correct
[x] liqui - correct
[x] livecoin - correct
[x] novaexchange - correct
[x] okcoin - correct
[x] poloniex - use quoteVolume
[x] quoine - correct
[x] viabtc - correct
[x] yobit - correct
[x] yunbi - correct

d0minicw0ng commented 7 years ago

@tmlee closing this issue