Add missing trade_page_url to exchanges (Part C) - Githubissues

coingecko / cryptoexchange

[UNMAINTAINED] Ruby library to query market data from cryptocurrency exchanges (https://www.coingecko.com)

https://www.coingecko.com

MIT License

297 stars 239 forks source link

Add missing trade_page_url to exchanges (Part C) #996

Open tmlee opened 5 years ago

tmlee commented 5 years ago

In reference to

https://github.com/coingecko/cryptoexchange/blob/master/lib/cryptoexchange/exchanges/binance/market.rb#L7
https://github.com/coingecko/cryptoexchange/blob/master/spec/exchanges/binance/integration/market_spec.rb#L20
Label the exchange in the README when implemented

add trade_page_url to list of the following exchanges

[ ] Bitstamp
[ ] Coincheck
[ ] Coinfalcon
[ ] Cointiger
[ ] Cryptaldash
[ ] Cryptopia
[ ] Dex.top
[ ] Digifinex

If not available, put the root url of the exchange

anuragagrawal0430 commented 5 years ago

I would like to work on this

tmlee commented 5 years ago

Thanks @anuragagrawal0430 , go ahead!

tmlee commented 5 years ago

@anuragagrawal0430 are you still working on this? otherwise i will open this up for grabs.