search

coinjar / react-native-wagmi-charts

A sweet & simple chart library for React Native that will make us feel like We're All Gonna Make It.
MIT License
588 stars 116 forks source link

Line gradient xDomain support, move tooltips with curve position #144

Closed cam-shaw closed 1 year ago

cam-shaw commented 1 year ago

BASED OFF OF https://github.com/coinjar/react-native-wagmi-charts/pull/143 (Expo Upgrade) Have made this PR a requirement of an Expo upgrade as I have added to the example project.

Related: https://github.com/coinjar/react-native-wagmi-charts/pull/103

When adding xDomain support, the following was not addressed:

This PR resolves these issues and can be seen in the example app.

Gradient Scale Fix

Before

https://github.com/coinjar/react-native-wagmi-charts/assets/6579750/dc9b67d1-2eb2-42c5-8e45-23e267882e45

After

https://github.com/coinjar/react-native-wagmi-charts/assets/6579750/ebf42e45-7dd9-400f-8bb3-c300e21eba3b

Tooltip x-position fix

https://github.com/coinjar/react-native-wagmi-charts/assets/6579750/f9fc2db7-2485-4690-9883-e21676e5564d

Dot x-position fix

Before

https://github.com/coinjar/react-native-wagmi-charts/assets/6579750/a51c740b-1011-4385-93dd-9b3b0d6b9e27

After

Is a small issue that remains where the dot shifts vertically when disabling xDomain, but I would say in practice this will be either on or off and not change during runtime

https://github.com/coinjar/react-native-wagmi-charts/assets/6579750/60110448-396c-4fbc-8d48-0cf60ddb3698

arancauchi commented 1 year ago

This looks great!