fix: line chart wont interpolate on data changes

coinjar / react-native-wagmi-charts

A sweet & simple chart library for React Native that will make us feel like We're All Gonna Make It.

MIT License

589 stars 116 forks source link

fix: line chart wont interpolate on data changes #149

Closed Amurmurmur closed 11 months ago

Amurmurmur commented 1 year ago

After upgrading to Expo v49 and react-native-reanimated v3 the chart will not interpolate on data switch due to previous value always being returned as null.

The same code works fine with Reanimated v2 and expo v48, most likely a buggy on the reanimated side (issue raised with them no feedback yet)

As of now this PR fixes it to support Reanimated v3 and Expo v49.

Amurmurmur commented 1 year ago

@arancauchi

LeoAnt02 commented 1 year ago

Hey @Amurmurmur , Thanks so much for this PR

Just curious, how is this tested on web ? Expo SDK49 introduce the metro web bundler that will slowly replace webpack

I think we should ensure that we support both

edit : I've tested the current version v2.3.0 on metro on web, expo 49, and reanimated v3.4.0 and the linear chart is working clean, no flicker, no issues