nandorojo
commented
6 months ago Looks good to me.
Closed alantoa closed 6 months ago
nandorojo
commented
6 months ago Looks good to me.
honeybadger26
commented
6 months ago Nicely done! Thanks @alantoa
alantoa
commented
6 months ago Hey @honeybadger26, could you please release it on npm? I noticed that it's available on GitHub but not on npm...
honeybadger26
commented
6 months ago Hi @alantoa. There were a few TypeScript errors that prevented the build (and publish) of the package. I aim to fix those and get a release out as soon as I can.
honeybadger26
commented
6 months ago @alantoa v2.5.1 has been released to npm :)
alantoa
commented
6 months ago @honeybadger26 thank you! 🙏
Why
During our project upgrade to expo sdk 51 and RN 0.74, i noticed that this lib some types are outdated with Reanimated and RN. This PR is compatible with the latest versions of Expo and RN.
How
Replacing Animated.SharedValue with SharedValue directly because renimated is deprecated with an old type.
During testing the example project, I noticed that many configurations and libraries in the project are already outdated. For instance, the app.json configuration is already out of date. You can refer to the latest documentation here for instructions on updating it.
And now I'm using Yarn 3 to integrate example and library code. It's simple and doesn't rely on too much configuration.
Test
I have tested the web and iOS app, and they all work well.
https://github.com/coinjar/react-native-wagmi-charts/assets/37520667/deafa421-1070-4ed3-9f3e-52f242e59927
Let me know if you guys have any questions about this PR!