search

coinjar / react-native-wagmi-charts

A sweet & simple chart library for React Native that will make us feel like We're All Gonna Make It.
MIT License
588 stars 116 forks source link

Import React #182

Closed honeybadger26 closed 2 months ago

honeybadger26 commented 2 months ago

Removing the React imports causes files to throw a React is not defined error (reported in https://github.com/coinjar/react-native-wagmi-charts/issues/179). This PR reverts the removal of these imports and updates the TypeScript rules to account for this.

arancauchi commented 2 months ago

Can we go with either import * as React from 'react'; or import React from 'react';?

honeybadger26 commented 2 months ago

Can we go with either import * as React from 'react'; or import React from 'react';?

Yep. I've gone with the latter since the React docs seem to prefer that way.