coinos / coinos-classic

A bitcoin wallet app
https://coinos.io/
GNU Affero General Public License v3.0
70 stars 17 forks source link

Update modules #10

Closed kmalakoff closed 5 years ago

kmalakoff commented 5 years ago

Hey Adam. I used ncu to update modules to the latest.

I didn't touch webpack and there's a lot of changes between webpack 3 and 4 plus quite a bit of custom webpack config. Have you thought about moving to webpack 4?

https://webpack.js.org/migrate/4/ https://medium.com/coursera-engineering/webpack-3-to-4-facing-the-known-unknowns-and-unknown-unknowns-cdfeb817faf8 https://medium.com/@sujankanwar/webpack-upgrade-from-3-to-4-687c6076c285

Also, I was thinking you might want to get rid of the direct github references here and in coinsos-server. I'm not sure how old those references are or if you can change you bolt fork to do it using the original module, but might be worth it to be back on the official channels.

rikur commented 5 years ago

LGTM