coinos / coinos-classic

A bitcoin wallet app
https://coinos.io/
GNU Affero General Public License v3.0
70 stars 17 forks source link

Self-payments not allowed at coinos.io #17

Closed jerzybrzoska closed 3 years ago

jerzybrzoska commented 3 years ago

When trying to send from one coinos account to another I get the following: payto_2020-12-30_10-49-33 Screenshot_2020-12-30_10-50-18 The issue only happens when I have two coinos accounts logged in at the same time in my tor browser (in two different tabs). Everything works well when I access the two accounts from two different browsers, let's say Chrome and Firefox. Is it because the accounts are hosted by the same node? Is there any work around this issue (other than self-hosting a full node)?

asoltys commented 3 years ago

Coinos is supposed to detect when you're paying another user and send it internally instead of over the lightning network. I tried to reproduce just now and it detected properly for me so not sure why it didn't work for you in this case.

asoltys commented 3 years ago

image

asoltys commented 3 years ago

Closing for now since I can't reproduce

jerzybrzoska commented 3 years ago

I figured out when the issue does not happen. Everything works well when I access the two accounts from two different browsers, let's say Chrome and Firefox. The issue only happens when I have two coinos accounts logged in at the same time in my tor browser (in two different tabs). Then the issue happens. I updated my screenshots in my first post. As you can see, when accessing the accounts at the same time from a Tor browser the server does not detect that the payment is going to be internal.

asoltys commented 3 years ago

Thanks for the update I'll try again with Tor

asoltys commented 3 years ago

I tested with Tor browser and still wasn't able to reproduce the issue. Is it possible your tor browser has some setting that's disabling websockets? The coinos server sends a message to the client over a websocket connection when it detects an internal transfer so I suspect you're not getting that message for some reason.

asoltys commented 3 years ago

Actually I am having an issue with websockets myself now when I access it with Tor at coinos.io instead of the onion site. I'll have to investigate more to see if I can figure out why but in the meantime you can try using the onion url: http://uzmim34vid5dkyzjxpel6zbkfz4qeqaaqe3gqrtbmekhxqglvzau73ad.onion/

asoltys commented 3 years ago

I still haven't been able to figure out the root cause of this so I've just put in place a javascript redirect that should automatically send you to the onion site if you're using tor browser.