search

coinpaprika / coinpaprika-api-nodejs-client

This library provides convenient way to use Coinpaprika.com API in NodeJS.
https://api.coinpaprika.com/
MIT License
46 stars 12 forks source link

Add support for "Quotes" in tickers for all coins #1

Closed dorian-coygo closed 5 years ago

dorian-coygo commented 5 years ago

Is it possible to add support for quotes in the tickers for all coins? 

quotes | stringDefault: "USD"Example: quotes=USD%2CBTC
Comma separated list of quotes to return. Currently allowed values: BTC, ETH, USD, EUR, PLN, KRW, GBP, CAD, JPY, RUB, TRY, NZD, AUD, CHF, UAH, HKD, SGD, NGN, PHP, MXN, BRL, THB, CLP, CNY, CZK, DKK, HUF, IDR, ILS, INR, MYR, NOK, PKR, SEK, TWD, ZAR, VND, BOB, COP, PEN, ARS, ISK

https://api.coinpaprika.com/#tag/Tickers/paths/~1tickers/get

Looks like we would just need to modify a few lines of code: https://github.com/coinpaprika/coinpaprika-api-nodejs-client/blob/master/index.js#L61

It also wouldn't be a breaking change since you already pass the "options" object as an argument.

marcin-jarota commented 5 years ago

Hello, we solved this problem with PR #3. Now you should use getAllTickers to get all tickers, getTicker has been marked as deprecated. For more information check out README.md