search

cointop-sh / cointop

A fast and lightweight interactive terminal based UI application for tracking cryptocurrencies 🚀
https://cointop.sh
Apache License 2.0
4.03k stars 311 forks source link

Show X axis labels on charts #184

Closed lyricnz closed 3 years ago

lyricnz commented 3 years ago

Per #156

lyricnz commented 3 years ago

Example

Screen Shot 2021-09-27 at 8 05 30 am

simon-anz commented 3 years ago

Should labels be optional, and/or configurable?

lyricnz commented 3 years ago

@miguelmota Now that we have time-series labels, if we are charting a single asset, and we get less data (to the left) than requested, should we chart just what we have (with accurate labels), rather than resampling to what was requested? This seems better (especially for "All Time" data). I'll make that change - but feel free to revert the next commit.

Eg EDG only has ~18 months of data

Screen Shot 2021-09-27 at 8 06 54 pm
miguelmota commented 3 years ago

I think it's fine to keep the labels enabled since they make the chart a lot more useful. We can always make them optional or configurable if there's more demand from users

miguelmota commented 3 years ago

Updates look good and works perfectly @lyricnz. Ready for merge