Track coin profit/loss over time

cointop-sh / cointop

A fast and lightweight interactive terminal based UI application for tracking cryptocurrencies 🚀

https://cointop.sh

Apache License 2.0

3.98k stars 311 forks source link

Track coin profit/loss over time #239

Closed matthiasbeyer closed 2 years ago

matthiasbeyer commented 2 years ago

I'm not sure how to articulate this properly,... sorry about that.

Right now, cointop can tell me that if I have X coins of CoolCoin, that this is worth $1 right now.

What it does not provide is some calculations that are only possible if it knows when I did buy CoolCoin and at what price.

If cointop would know that, it would be possible to tell me where my "breakeven" point would be, how much +/- I currently have with my investment... all these nice things.

Would implementing such a functionality be possible?

lyricnz commented 2 years ago

I don't know enough about how the UI works to add this feature (I'm just a contributor). It definitely be possible at the data layer, but would require changing the format of the holdings configuration - which would need to maintain backward compatibility.

Thoughts:

why would you need to know "when"? your profit only depends on the price
more columns on portfolio chart (original$ delta$ delta%)
would also need to specify currency of the purchase
and if the purchase currency is not the same as current displayed currency, would need to convert

lyricnz commented 2 years ago

This appears to be a duplicate of the second part of #75

lyricnz commented 2 years ago

I started a PR for this #243 . Happy for review/comments/fixes etc.

matthiasbeyer commented 2 years ago

Closing because of duplicate.