Closed vuon9 closed 2 years ago
I have fixed and re-test on Windows and WSL Ubuntu. Please help me to review again @lyricnz 😀
Should we me making two distinct (or three??) binding for Shift keys, to cover the difference in behaviour between terminals?
P, shift+p, shift+P
Does one of these not happen?
On Windows, both shift+p and shift+P can happen, but can't on non-Windows. I think we should keep it simple as using only the rune value.
Why the changes to go.sum? Other than that, LGTM
Why the changes to go.sum? Other than that, LGTM
Oh, sorry, that was an outdated one. I've updated (by go mod
)!
Looks good! Merging