Fix some shift key problems

cointop-sh / cointop

A fast and lightweight interactive terminal based UI application for tracking cryptocurrencies 🚀

https://cointop.sh

Apache License 2.0

3.98k stars 311 forks source link

Closed vuon9 closed 2 years ago

vuon9 commented 2 years ago

Ignore checking modifiers when trap the shortcut due to difference of OS, it is a fixed for any combo of shift+[key] on Windows.
Trap shift mod in search input (currently, couldn't use colon)

vuon9 commented 2 years ago

I have fixed and re-test on Windows and WSL Ubuntu. Please help me to review again @lyricnz 😀

lyricnz commented 2 years ago

Should we me making two distinct (or three??) binding for Shift keys, to cover the difference in behaviour between terminals?

P, shift+p, shift+P

Does one of these not happen?

vuon9 commented 2 years ago

On Windows, both shift+p and shift+P can happen, but can't on non-Windows. I think we should keep it simple as using only the rune value.

lyricnz commented 2 years ago

Why the changes to go.sum? Other than that, LGTM

vuon9 commented 2 years ago

Why the changes to go.sum? Other than that, LGTM

Oh, sorry, that was an outdated one. I've updated (by go mod)!

miguelmota commented 2 years ago

Looks good! Merging