Fix Coin ID for Coinmarketcap

cointop-sh / cointop

A fast and lightweight interactive terminal based UI application for tracking cryptocurrencies 🚀

https://cointop.sh

Apache License 2.0

3.94k stars 309 forks source link

Fix Coin ID for Coinmarketcap #279

Closed vuon9 closed 2 years ago

vuon9 commented 2 years ago

https://github.com/cointop-sh/cointop/blob/8b8db3bd13c366a9657434af71b61400e6b01ad9/pkg/api/impl/coinmarketcap/coinmarketcap.go#L79-L93

Coinmarketcap data is using v.Name as ID for Coin struct, but it seems wrong due to Coinmarketcap has its ID, and the name is not guaranteed to be unique.

Related comments: #275