search

cointop-sh / cointop

A fast and lightweight interactive terminal based UI application for tracking cryptocurrencies 🚀
https://cointop.sh
Apache License 2.0
3.94k stars 309 forks source link

Fix conversion key can be triggered in any menu #289

Closed vuon9 closed 2 years ago

vuon9 commented 2 years ago

The problem is: Given I stay in help menu When I use any key which also been mapping to country currency Then the coin accidentally get convert to the currency

Have fixed by ensure the convert menu is visible, otherwise it shouldn't trigger the convert func.

lyricnz commented 2 years ago

Yeah, there was a similar bug before, when someone kept getting converted hitting Q to exit the menu. We really should separate all the "screens" into separate views, and apply the bindings only to the correct view. This is OK workaround in the meantime.

vuon9 commented 2 years ago

I agree. We also can have better help menu to describe the available shortcut keys by views separately.