search

cointop-sh / cointop

A fast and lightweight interactive terminal based UI application for tracking cryptocurrencies 🚀
https://cointop.sh
Apache License 2.0
3.98k stars 311 forks source link

[New API] Binance #76

Open tom2411 opened 3 years ago

tom2411 commented 3 years ago

Hello, I wanted to ask if you plan to add the Binance Api on the project ?

Tom

GustavoGB commented 2 years ago

Hi guys, I will try to make a solution for this ok?

GustavoGB commented 2 years ago

Hi @miguelmota and @tom2411 hope you guys are doing well! I was doing some research and ended up finding this Golang SDK based on the binance api. This is the following repository : https://github.com/adshao/go-binance.git . I made a quick script in Go using the library that is able to use the API keys to retrieve the Ticker Price based on Binance data. But it has to deal with secret keys in a better way, maybe using .gitignore or some kind of criptography. I will think a better way to deal with the secret keys from binance and make a pull request :) Cheers!

lyricnz commented 2 years ago

The secrets should be user-specific and in user local config only, and not committed to git. I started (a tiny bit) on this some time back, using the same library, but ran out of time https://github.com/lyricnz/cointop/commit/226f54d34f5e3c6f023eda52190f6420b8983121

GustavoGB commented 2 years ago

@lyricnz oh that's nice, Can I try to implement some TODOs functions in this branch, like get all coin data?

lyricnz commented 2 years ago

Go for it; you might need to fork or clone it.