Closed NisargShah1410 closed 1 year ago
These changes don't appear to add value. It breaks code indenting, alters public API, renames variables for no particular reason, de-inlines code (with no improvement), adds unnecessary constants, moves code for no apparent reason, and increases code complexity.
This PR would be useful if it fixed bugs, added useful features, or improved documentation.
Applied different kinds of refactoring to multiple parts of code as below:
Extract method:
Rename variable:
Class : BTree
Method : writeCachePrimer
Line no. : 1365
Variable : dout
Class : BTreeValue
Method : compactCheck
Line no. : 108
Variable : fLen
Introduce explaining variable :
Class : BTreeValue
Method : action
Line no. : 376
Variable : dout
Class : BTreeValue
Method : action
Line no. : 380
Variable : dout
Decompose conditional:
Move method:
Replace conditional with polymorphism:
Push down method:
Extract class: