cojen / TuplDB

TuplDB is a high-performance, concurrent, transactional, scalable, low-level embedded database.
GNU Affero General Public License v3.0
110 stars 22 forks source link

Refactored code with different kinds of refactoring techniques #119

Closed NisargShah1410 closed 1 year ago

NisargShah1410 commented 1 year ago

Applied different kinds of refactoring to multiple parts of code as below:

Extract method:

Rename variable:

Introduce explaining variable :

Decompose conditional:

Move method:

Replace conditional with polymorphism:

Push down method:

Extract class:

broneill commented 1 year ago

These changes don't appear to add value. It breaks code indenting, alters public API, renames variables for no particular reason, de-inlines code (with no improvement), adds unnecessary constants, moves code for no apparent reason, and increases code complexity.

This PR would be useful if it fixed bugs, added useful features, or improved documentation.