search

cojs / busboy

Busboy multipart parser as a yieldable
154 stars 24 forks source link

emit error when busboy limits is reached #13

Closed haoxins closed 10 years ago

jonathanong commented 10 years ago

HMMM my only issue here is that the errors aren't very easy to catch by devs. we should have some err.code properties and probably err.status = 400 as well and document them all. i wish busboy did this itself. see: https://github.com/jshttp/jshttp.github.io/issues/35

kevinprotoss commented 10 years ago

Hello,

Thanks coderhaoxin, I haven't tried your pr yet, but I think it should work. This is also what I intended to do before. I still wait for the new version with this merge. I agree with jonathanong, it should emit some Errors with definite code or status.

Kevin

jonathanong commented 10 years ago

@coderhaoxin feel free to push and publish