search

cojs / co-body

Parse request bodies with co
MIT License
325 stars 42 forks source link

Added support for request body inflation and added relevant tests #40

Closed bminer closed 8 years ago

bminer commented 8 years ago

Added support for request body inflation and added relevant tests Release 4.1.0 This closes issue #38.

Please do not merge this PR until the following inflation pull request is merged and published to NPM. 1 test will fail until this PR is merged. https://github.com/stream-utils/inflation/pull/14

bminer commented 8 years ago

The Travis CI builds will fail because this PR references inflation@1.1 in the package.json file, which has not yet been published. Please wait for https://github.com/stream-utils/inflation/pull/14 to be merged and published to NPM before merging this PR. Thanks and sorry for the confusion.

bminer commented 8 years ago

One bug that I noticed is that the Content-Length header is passed to raw-body, which causes a body length mismatch whenever a Content-Encoding header is provided. This needs to be fixed.

EDIT: Fixed by commit 1d833cf

bminer commented 8 years ago

This can now be safely merged. All tests passing.

fengmk2 commented 8 years ago

@bminer wait for you to fix these, and then I will merge and release a new minor version.

fengmk2 commented 8 years ago

Landed b00173441920ee65b1691cd8fd18d51a9d043107

fengmk2 commented 8 years ago

4.2.0

bminer commented 8 years ago

Thank you!