search

cojs / co-body

Parse request bodies with co
MIT License
325 stars 42 forks source link

Update dependencies and fix for JSON poisoning #71

Closed thetutlage closed 3 years ago

thetutlage commented 5 years ago

This PR contains couple of commits covering

  1. Updating dependencies and adjusting code after the update. Mainly koa@2 is used for testing and syntax has been adjusted automatically.
  2. Added a fix for JSON poisoning
codecov-io commented 5 years ago

Codecov Report

Merging #71 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #71   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines          91     93    +2     
=====================================
+ Hits           91     93    +2
Impacted Files Coverage Δ
lib/json.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db6041c...a3b09e6. Read the comment docs.

MarkHerhold commented 5 years ago

Per the npm page -

This module has moved and is now available at @hapi/bourne. Please update your dependencies as this version is no longer maintained an may contain bugs and security issues.

MarkHerhold commented 5 years ago

@dead-horse @popomore What are your thoughts on this PR? Is is something you guys think should be included in co-body or something that should be handled downstream, e.g. in JSON validation libraries?

zxbodya commented 4 years ago

any updates on this?

fixing the JSON poisoning possibility sounds kind of important… however, I am also not sure if it should be handled here or somewhere downstream

codecov-commenter commented 4 years ago

Codecov Report

Merging #71 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #71   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           91        93    +2     
=========================================
+ Hits            91        93    +2
Impacted Files Coverage Δ
lib/json.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db6041c...211bd33. Read the comment docs.