search

cokelaer / bioservices

Access to Biological Web Services from Python.
http://bioservices.readthedocs.io
Other
279 stars 61 forks source link

Fix for issue #226 #232

Closed GianArauz closed 2 years ago

GianArauz commented 2 years ago

I think that the three columns causing problems with uniprot get_df() are:

'ft_ca_bind' 'ft_np_bind' 'ft_metal'

After commenting them, get_df() works fine again.

PS: This is my first (or second) pull request. Please, let me know if I proceed correctly and sorry in advance if something is not adequate.

cokelaer commented 2 years ago

@GianArauz thanks a lot for this pull request. Well, yes, you proceed correctly. You have created a forked and submitted a pull request. I have approved the workflow so that is will now run the tests for you. I'll double check the uniprot documentation before though. looks like they have changed the API very recently. I may have comments by tomorrow before merging the pull request. thanks again for spotting and fixing this issue.