Closed ArnaudBelcour closed 1 year ago
@ArnaudBelcour thanks for the fix. I have merged your PR. as for your question, indeed, could be renamed compressed but for back compatibility, as you mentionned, I will keep 'compress' for now. The uniprot variable is indeed called compress as well. I tend to keep the name of the services except if it is too esoteric and not meaningful.
Hi,
I was trying to download compressed fasta from UniProt using bioservices
search
. But this function did not return compressed result, instead it returns an uncompressed fasta string.An example:
Returns:
It is caused by wrong parameter and value in the search function. This Pull request should fix this issue.
Do you think that the variable
compress
of search function should be renamed to matchcompressed
? I think not as it breaks compatibility with script using this function but as the other parameters seem to be matching the ones of Uniprot, I prefer asking this.