Review issues

[vr8hub]

• [x] We try to avoid names in the short description, and it doesn't require much detail. For example, "A chronicle of the First…Cavalry in the Spanish-American war." (Just an example; I haven't read it, so use your own words. :)
• [x] "4 of the 12" in the long description should probably be "four of the twelve" in keeping with our style guide.
• [x] You can use <br/> and <b>s in the dedication text to match the formatting of the text. For the signature and location, those should probably be separate paragraphs so they can be formatted separately (e.g., currently, the <b> for the signature is redundant, since the CSS targets the p:last-child with small-caps as well). Neither the signature nor the dateline should be centered; you can use a footer there to target them.
• [x] The two abbreviations in the chapter 6 letter dateline should be be tagged as abbreviations.
• [x] Just a note that it's OK to keep the appendices in separate files if you want (appendix-a, etc.). If you keep them in the same file, it's probably worth forcing a page-break in CSS for each subsection since they're so large.
• [x] Since the appendix A letter is the entirety of that appendix, let's target it and override the normal blockquote left/right margins to 0. (When a blockquote is in the middle of text, the margins are part of what indicate it's separate from the text, but when the blockquote is the entirety of the text, the left/right margins aren't usually necessary.)
• [x] You put the "sender" tag on the paragraph, so Roosevelt's title picked up the small caps.
• [x] I don't think semantically that the "Forwarded…" section qualifies as a postscript.
• [x] The "First Endorsement" paragraph can be targeted to format it per the scans.
• [x] The endorsement dateline should have a <br/> to split the lines per the scans. As it is, the period after "Corps." which indicates the end of the line makes it look like Corps. is an abbreviation.
• [x] I would do the same with the signature, so that his (Shafter) title is on a separate line per the scans.
• [x] For Appendix B, I don't think the material surrounding the letters is a letter. That is, "the following is a report…". So the first three paragraphs are just text, then there's the first letter, then "After Colonel Roosevelt had taken…" is just text, then the next letter, then "Major M. W. Wood…" and the next paragraph is text, then the last cable message. This represents the actual structure of the appendix, and doing so allows, e.g., the signatures on the second letter to be in a footer as they should be, and so forth.
• [x] Same notes on the signatures, etc. as in Appendix A above.
• [x] The first blockquote in Appendix C is a portion of a letter, so should have letter semantics.
• [x] Norton's note ("On July 1st I, together …") should be in a blockquote, letter semantics. (We count notes as letters for semantic purposes.)
• [x] Same for Richard Harding Davis' immediately following.
• [x] Same for the section of Woods letter than begins "A word in regard to the number of troops…". (All three above are also blockquotes in the scans, i.e. are set off from the text.)
• [x] Appendix E is missing, is there a reason? I saw the discussion about leaving out the muster roll (good call!), but nothing about this one, and it looks to have interesting/relevant material.
• [x] Sorry, I missed this the first time. There is a poem (epigraph) following the dedication in the scans that is also missing. This is in all the editions I looked at (four or five), so we do need it.

[vr8hub]

• [x] I hadn't gotten to checking the links yesterday. The metadata entry for the book's wiki page (meta property="se:url.encyclopedia.wikipedia">) is for the Rough Rider disambiguation page; this was likely done automatically by se create-draft. I could not find a separate Wiki page for the book, so unless you can find one, I believe this metadata entry can be deleted.

[vr8hub]

• [x] I received clarification from Alex today (the next version of the manual will have this in it), but our Wikipedia URLs should be for English pages only. The artist's wiki metadata entry can thus also be removed, since he doesn't have an English page.

[colagrosso]

I haven't started transcribing Appendices E, F, and G yet, but I thought I would update my progress on the other tasks here. I completed them all and took the liberty of checking them off above. My commit history matches the task order pretty closely, but I can link to specific commits if there's a question of whether I addressed something you raised.

Also, thank you very much for correcting my approach in Appendix B:

For Appendix B, I don't think the material surrounding the letters is a letter.

I was way off there, and I didn't notice the subtle changes in which parts were set off from the rest of the text. Also, thank you for finding the roughriders0000unse IA scans. I found those easier to read, and they of course have the other appendices. I added them as a second <dc:source>.

[vr8hub]

Thanks for the update, great progress! Yes, the checkboxes were for your convenience, so that's perfect. I'll review it again once you're done, so don't worry about commit links.

Unless there's something in the original scans that isn't in the new ones, you don't need both sources; just the second one is sufficient if that's the one you're going with.

[colagrosso]

Ok, I added Appendices E, F, and G from the scans (as D, E, and F here), so this is ready for you to review again.

There wasn't anything in the original scans that isn't in the new ones, I also took your advice and listed just roughriders0000unse as the only source.

[colagrosso]

One additional reviewer note: There's some extra styling in the scans—mostly italics—that I didn't translate to appendix-d.xhtml and appendix-e.xhtml. Examples would be the titles of the senders of letters, such as:

Major-General United States Army.

or a different example:

To be Brigadier-General by Brevet.

I'm open to feedback on adding more styling and/or what semantics to add. You might have given this feedback above already for Appendices A and B, and if so I'm sorry I missed it. Once I get them right, I'll make them all consistent.

[vr8hub]

Great work, Mike! I'm about to have to leave for an engagement this evening, but I wanted to give you what I've found so far.

• [x] I don't think we need the separate "Appendices" section. We generally don't do that unless the scans call for it, and in this case they don't. IOW, the appendix-a can be at the same level as the rest of the chapters. The appendix titles should then also include "Appendix", e.g. "Appendix A", "Appendix B", etc.
• [x] I should have caught this before, but there are some thematic breaks that are missing. For example, on page 229 of the scan, the paragraph "The regiment was a wholly exceptional…" has a vertical space between it and the paragraph above. That's a thematic break, and we indicate those with a <hr/> (see SEMOS 4.1.2.2.7. There are another couple of them in Appendix D (e.g. after paragraph that ends "Each left a widow and young children."); I didn't give the rest of the book a thorough going over, but you should. Note that a blockquote (e.g. letter) also causes a break like that, so the <hr/> is only needed when it's an actual thematic break between two "normal" paragraphs.
• [x] As you noted, the titles of the letter senders should be styled differently than the signatures. We're not slavish about this, so the italics aren't strictly necessary, but I don't see a reason not to. Either way, they shouldn't have the small-caps of the signatures; this is again caused by the z3998:sender being included on the <p> containing the signatures rather than the <span>. If you want to italicize the titles, you can just surround the titles themselves with unsemanticated italics (<i>).
• [x] Some of the letters in Appendix D are elided, i.e. have a string of periods across the page. This indicates that part of the letter was removed (probably since they were unrelated to Roosevelt). I honestly don't remember if I've encountered this before in non-poetry, but I don't see any reason we wouldn't do the same thing here. See SEMOS 7.5.7 for the details.
• [x] In that first letter in Appendix D, the sentence that specifies the officers doesn't need the inner blockquote. That's just part of the letter. Same for the "I cannot speak too highly…" paragraph in the second letter; that doesn't need a blockquote, either. (Note the margins are the same in both cases in the scans.)
• [x] The "Officers" in that letter should be targeted to center it and give it a top margin to separate it from the paragraph above, per the scans.

Sorry to have to leave without finishing, but I'll try to get back to it tomorrow or Monday!

[colagrosso]

Thanks a bunch for the quick feedback, and I totally understand you're not done. I addressed what you noted so far.

A few comments:

• Because the appendices are backmatter instead of bodymatter they are still treated separately in the table of contents. But they are otherwise at the same level as the rest of the chapters.
• Sorry I missed the thematic breaks. I checked the rest of the book, and they are easy to find now that I see what I'm looking for. There were only the three that you already pointed about above.
• I didn't know what those strings of periods across the page meant, thanks for explaining. I tried blockquotes there, so that was a related mistake. You're right that the margins were the same.

[vr8hub]

Sorry for the confusion—yes, I just meant the appendices didn't need to be children of a separate "Appendices" section.

Good job catching the eyewitness and roman numeral in the new appendices; I saw them at a glance yesterday, but forgot them by the time I did the write-up. :)

I think the only piddly things left are:

• [x] The "Nominations by the President" line in appendix D should be targeted and given 1em top/bottom margins to match the scan.
• [x] While you're doing that, you can target the "To be Colonel…" and "To be Brig…" lines and format them as italic in the CSS rather than with <i> in the text. Alex generally prefers to use CSS when the format is being applied to the entire line as it is here. (Although he has made exceptions, we never know when he's going to do so. :)
• [x] In the CSS, you can combine the append-a > blockquote and appendix-e blockquote into a single element. And, I think we want to do that for Appendix D as well. Since everything in Appendix D is a letter, even though it's multiple letters, I don't see any reason to indent the left/right margins. I believe Alex will agree, but we'll ask for forgiveness instead of permission. :)
• [x] The bracketed paragraphs at the top of the two sections in Appendix E should also be targeted to give them a bottom margin (1em?) so they're separated from the text.

After that, I think you're good to go. Once again, great job; there was a lot of tricky stuff here, especially on all the appendices.

[colagrosso]

Right on, thanks. Those last four changes were small, but they made the formatting look a lot better. It's good to know those approaches.

Thanks a bunch for the review, and double thanks for your contributions to the tools. They're great.