search

colbyfayock / html-webpack-partials-plugin

🛠 Easy HTML partials for Webpack without a custom index!
MIT License
68 stars 20 forks source link

set html webpack plugin as peer dependency #14

Closed avivshafir closed 4 years ago

avivshafir commented 4 years ago

html webpack should be a peer dependency of this library

see similar libraries: https://github.com/GoogleChromeLabs/preload-webpack-plugin/blob/master/package.json https://github.com/swimmadude66/html-webpack-link-type-plugin/blob/develop/package.json

It should prevent the problem of two instances of html webpack plugin being installed

I think I encountered this related issue: https://github.com/jantimon/html-webpack-plugin/issues/1091

colbyfayock commented 4 years ago

@avivshafir thank you! do you want to add it as a dev dependency then too? that way it'll get installed when developing this package locally, but still wont get pulled in for others using it

avivshafir commented 4 years ago

@colbyfayock yes, It is in dev dependency also

colbyfayock commented 4 years ago

oops i didn't realize it was already there, weird it was in both places before. thanks for this!

colbyfayock commented 4 years ago

just published 0.5.6