search

colbyfayock / html-webpack-partials-plugin

🛠 Easy HTML partials for Webpack without a custom index!
MIT License
68 stars 20 forks source link

Update example link to Netlify URL #17

Closed ssmith353 closed 4 years ago

ssmith353 commented 4 years ago

Hey @colbyfayock, After I submitted this PR I noticed your netlify samples site, https://html-webpack-partials-plugin.netlify.app/variables/dist/

I now see why you had the encoding as you did..

Would it be possible to update the readme link in the repo to point to the netlify URL, rather than the repo link

When I was reviewing it, I noticed the encoding and was confused what I was actually supposed to put in the webpack.config file.

Thanks for your time!

colbyfayock commented 4 years ago

@ssmith353 yes! Sorry about that... I can definitely add some clarification. Would you prefer to do it so that you can still get credit for a commit instead of this one? otherwise, I can update that

I think I should probably note why it's encoded like that, but also include both the Github link to examples AND the netlify link to examples

ssmith353 commented 4 years ago

Hey @colbyfayock, I updated my PR to update the readme to point to the Netlify URL. Let me know if you see anything else I should change!

Thanks for your work on this project btw!

colbyfayock commented 4 years ago

looks great to me, thanks for grabbing that @ssmith353

happy to hear this works been helpful for you :)