colbyfayock / next-wordpress-starter

📝 Bring WordPress to the static world with Next.js
https://next-wordpress-starter.spacejelly.dev
MIT License
1.2k stars 293 forks source link

Microformat #44

Open colbyfayock opened 4 years ago

colbyfayock commented 4 years ago

We should add logical microformats throughout the site

http://microformats.org/ https://microformats.io/ https://developer.mozilla.org/en-US/docs/Web/HTML/microformats

arifsetyo21 commented 4 years ago

which part to add microformat?

colbyfayock commented 4 years ago

hey @arifsetyo21 i'm hoping to add as much coverage as makes sense, so that includes author information, post information, website information. it would be great if as part of this issue, the person who takes it tries to figure out what all make sense

arifsetyo21 commented 4 years ago

Okay, can i do this issue?

colbyfayock commented 4 years ago

sure thing :) let me know if you have any issues!

doingandlearning commented 4 years ago

I don't know if this belongs in this issue but it would be good to have everything required for webmentions leveraging of microformats in here.

doingandlearning commented 4 years ago

(I'll find a link!)

colbyfayock commented 4 years ago

yes! that was one of the things i had in mind when thinking about it. it would be cool as that information is valuable for services that can provide a rich experience and if im not mistaken even search engines use it

colbyfayock commented 4 years ago

hey @arifsetyo21 checking in - are you having any luck with this?

colbyfayock commented 4 years ago

unassigning this to allow someone else to work on it

Azanul commented 2 years ago

@colbyfayock I'll take this up if no one else is working on it. Also, I think this issue should be split in two as there could be too many changes at once.

colbyfayock commented 2 years ago

@Azanul sounds good to me! would love to hear your thoughts then before moving forward including the work that needs to be done and what you see as the 2 issues

Azanul commented 2 years ago

@colbyfayock I meant 2 PRs as there can be many changes.

colbyfayock commented 2 years ago

Got it, I would still like 2 issues to have concise details around the problems each are solving so that we're not creating 2 PRs for the sake of creating 2 PRs

Azanul commented 2 years ago

@colbyfayock I've read about microformats now. What I understood is we'll have to add appropriate class names to all components, right?

colbyfayock commented 2 years ago

from what i understand i think thats part of it. i was also under the impression there would be more attributes than classes, such as "roles" and such, but i haven't looked too deeply into it

Azanul commented 2 years ago

You mean adding rel attribute? https://developer.mozilla.org/en-US/docs/Web/HTML/microformats#microformats_rel_property_examples

colbyfayock commented 2 years ago

yeah haha that might be it! :D

i trust whatever you find out through your research

Azanul commented 2 years ago

Let's divide it in either of these two ways:

  1. per component
  2. all components per required task (i.e., rel attribute and class name)
colbyfayock commented 2 years ago

i don't think it makes sense to create a new PR for every component, but if you'd like to break up the work another way, such as one for pages and one for components, I'm open to that

Azanul commented 2 years ago

Not one PR for each component but one for half of them and another for other half

colbyfayock commented 2 years ago

let's do pages vs components as that sounds a little bit like a more logical difference

/src/pages vs /src/components

that sound good?

Azanul commented 2 years ago

By vs you mean one PR for pages and one for components right?

Azanul commented 2 years ago

Let me take up components then

colbyfayock commented 2 years ago

yup, sounds great