"game is lost" sound on closing games

[GoogleCodeExporter]

What steps will reproduce the problem?
1. start a game
2. you win the game, not finish it, whatever works the asame
3. close the tab
4. you hear "game is lost" sound

What is the expected output? What do you see instead?
either no sound or "close tab" sound should be played, definitely not this
one (especially not when I have already won the game ;-)

Does it happen every time?
yes, it does

What version of the product are you using?
0.10 alpha

Did you use an installed version of PyChess or did you run in from a
tarball/svn?
deb

Original issue reported on code.google.com by pe3...@gmail.com on 10 Jan 2009 at 1:05

[GoogleCodeExporter]

I can reproduce this.
There is however the issue about quitting games: When you quit an unfinished 
game, we
say you resigned it, so in this single case the sound is right, right?

Original comment by lobais on 9 Feb 2009 at 4:14

• Changed title: "game is lost" sound on closing games
• Changed state: Accepted

[GoogleCodeExporter]

I do not remember, but as I see in 2 - it makes sound for "losing the game" 
even if
you have already won the game, when you close the tab - so it makes no sense 
this way...
Sure, when you quit unfinished game, ok, "game is lost" sound is reasonable.

Original comment by pe3...@gmail.com on 9 Feb 2009 at 11:42

[GoogleCodeExporter]

I have commited a fix for this. Please confirm if it works as expected.

Original comment by lobais on 10 Feb 2009 at 6:37

• Changed state: Started

[GoogleCodeExporter]

Checked in "rev 1401" and works as follows:
- "lost" sound when game is lost (tried to resign)
- "lost" sound when closing unifinished game
- NO sound when closing finished game

Seems fine to me this way.

Original comment by pe3...@gmail.com on 23 Feb 2009 at 5:47

[GoogleCodeExporter]

Original comment by lobais on 23 Feb 2009 at 6:21

• Changed state: Fixed